raise DeprecationWarning for a targetless timeline drawer #13601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
40 tasks
40 tasks
ElePT
reviewed
Feb 14, 2025
There was a problem hiding this comment.
HI @1ucian0, thanks for opening this PR. Looking at the reno I was wondering if there is any work already in place to actually require the target in the timeline drawer from 2.0? I just want to make sure that the removal doesn't slip through the cracks.
|
maybe it helps to answer that question if i write the removal with |
|
Added an issue to keep track of the removal in 2.0. Merging! |
ElePT
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #13247, the timeline drawer was raising a
PendingDeprecationWarningwhentargetwas not specified. Can it be moved toDeprecationWarningin 1.4?cc: @mtreinish