Fix type of basis_gates in BasicSimulator configuration
#13385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`basis_gates` was getting set to `Target.operation_names`, which is a `dict_keys` instance (maybe that should be changed to a more basic type?), while typically `basis_gates` is a list. `dict_keys` instances can not be deep copied, so code that usually deep copies a backend's configuration could not work. Deep copying the configuration can happen for example when using the `BasicSimulator` with sampler class like `qiskit_ibm_runtime.SamplerV2` that puts the backend into its options and then tries to deep copy the options.
|
One or more of the following people are relevant to this code:
|
|
The configuration model is deprecated any way, but I think it is worth treating this as a bugfix since it blocks a usage pattern that is not trying to use the configuration. It came up in Qiskit Slack here. |
jakelishman
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Thanks Will, this seems straightforward and eases a pain point in the transition. I'll backport it to the 1.2 series, though at present we hadn't been planning to push out a further release on that branch. If it's a big annoyance, it's easy for us to put out a new patch release.
Pull Request Test Coverage Report for Build 11614986392Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
`basis_gates` was getting set to `Target.operation_names`, which is a `dict_keys` instance (maybe that should be changed to a more basic type?), while typically `basis_gates` is a list. `dict_keys` instances can not be deep copied, so code that usually deep copies a backend's configuration could not work. Deep copying the configuration can happen for example when using the `BasicSimulator` with sampler class like `qiskit_ibm_runtime.SamplerV2` that puts the backend into its options and then tries to deep copy the options. (cherry picked from commit 09d1006)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
…13386) `basis_gates` was getting set to `Target.operation_names`, which is a `dict_keys` instance (maybe that should be changed to a more basic type?), while typically `basis_gates` is a list. `dict_keys` instances can not be deep copied, so code that usually deep copies a backend's configuration could not work. Deep copying the configuration can happen for example when using the `BasicSimulator` with sampler class like `qiskit_ibm_runtime.SamplerV2` that puts the backend into its options and then tries to deep copy the options. (cherry picked from commit 09d1006) Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basis_gateswas getting set toTarget.operation_names, which is adict_keysinstance (maybe that should be changed to a more basic type?), while typicallybasis_gatesis a list.dict_keysinstances can not be deep copied, so code that usually deep copies a backend's configuration could not work. Deep copying the configuration can happen for example when using theBasicSimulatorwith sampler class likeqiskit_ibm_runtime.SamplerV2that puts the backend into its options and then tries to deep copy the options.