Fix oversights in generate_preset_pass_manager
#12799
Merged
+33
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ElePT
commented
Jul 22, 2024
releasenotes/notes/add-generate-preset-pm-global-import-efb12f185f3f738b.yaml
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 10075733597Details
💛 - Coveralls |
…e not migrated from transpile to generate_preset_pm with the others.
|
One or more of the following people are relevant to this code:
|
ElePT
commented
Jul 24, 2024
Comment on lines
-342
to
-343
| initial_layout = _parse_initial_layout(initial_layout) | ||
| approximation_degree = _parse_approximation_degree(approximation_degree) |
There was a problem hiding this comment.
Before this PR, setting a custom initial_layout or approximation_degree could lead to different results on generate_preset_pass_manager vs transpile, while the rest of inputs would be consistent.
ElePT
commented
Jul 24, 2024
Comment on lines
+17
to
+20
| - | | ||
| A series of input-handling inconsistencies between :func:`.transpile` and :func:`.generate_preset_pass_manager` | ||
| have been fixed. These inconsistencies would lead to different transpilation outputs for the same inputs, | ||
| or :func:`.generate_preset_pass_manager` failing for certain input combinations accepted by :func:`.transpile`. |
There was a problem hiding this comment.
Most of the inconsistencies were fixed in the previous PR but we didn't have any reno to refer to. Given that there have been issues about these inconsistencies, I think it would be good to mention that they will no longer happen (but we can adjust the wording).
mtreinish
approved these changes
Jul 24, 2024
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
* Fix oversight from Qiskit#12185 where two input parsing functions were not migrated from transpile to generate_preset_pm with the others. * Add fix to reno from Qiskit#12185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a couple of issues that should have been addressed in #12185. Found while working on #12762 and changes built on top of it (must be rebased).
Details and comments