Skip to content

Pin scipy to 1.13.1 to bypass CI failures #12654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2024
Merged

Pin scipy to 1.13.1 to bypass CI failures #12654

merged 3 commits into from
Jun 25, 2024

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Jun 25, 2024

Summary

Temporary scipy pin to get CI going.

Details and comments

@ElePT ElePT requested a review from a team as a code owner June 25, 2024 09:32
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

jakelishman
jakelishman reviewed Jun 25, 2024
View reviewed changes
@ElePT ElePT mentioned this pull request Jun 25, 2024
Closed
jakelishman
jakelishman approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mergifyio backport stable/0.46 stable/1.1

edit: huh, turns out that Mergify doesn't watch approval comments for commands.

@jakelishman
Copy link
Member

@Mergifyio backport stable/0.46 stable/1.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024 •
edited
Loading

backport stable/0.46 stable/1.1

✅ Backports have been created

@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jun 25, 2024
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9660176255

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 89.725%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.6%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 9650973845: -0.03%
Covered Lines: 63753
Relevant Lines: 71054
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9660175943

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.743%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 4 92.11%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 9650973845: -0.01%
Covered Lines: 63766
Relevant Lines: 71054
💛 - Coveralls

@ElePT ElePT enabled auto-merge June 25, 2024 10:48
@ElePT ElePT added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 1ed5951 Jun 25, 2024
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@ElePT @mergify
Pin scipy to 1.13.1 to bypass CI failures (#12654)
7d21332 
* Pin scipy to 1.13.1 to bypass CI failures

* whoops

* double whoops

(cherry picked from commit 1ed5951)
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@ElePT @mergify
Pin scipy to 1.13.1 to bypass CI failures (#12654)
470b795 
* Pin scipy to 1.13.1 to bypass CI failures

* whoops

* double whoops

(cherry picked from commit 1ed5951)

# Conflicts:
#	constraints.txt
This was referenced Jun 25, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 25, 2024
@mergify @ElePT
Pin scipy to 1.13.1 to bypass CI failures (#12654) (#12657)
9cdeac8 
* Pin scipy to 1.13.1 to bypass CI failures

* whoops

* double whoops

(cherry picked from commit 1ed5951)

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Jun 25, 2024
@mergify @ElePT
Pin scipy to 1.13.1 to bypass CI failures (backport #12654) (#12656)
1f1b89f 
* Pin scipy to 1.13.1 to bypass CI failures (#12654)

* Pin scipy to 1.13.1 to bypass CI failures

* whoops

* double whoops

(cherry picked from commit 1ed5951)

# Conflicts:
#	constraints.txt

* Update constraints.txt

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
@mtreinish mtreinish deleted the ElePT-patch-1 branch June 27, 2024 19:58
Procatv pushed a commit to Procatv/qiskit-terra-catherines that referenced this pull request Aug 1, 2024
@ElePT @Procatv
Pin scipy to 1.13.1 to bypass CI failures (Qiskit#12654)
af4b941 
* Pin scipy to 1.13.1 to bypass CI failures

* whoops

* double whoops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElePT @qiskit-bot @jakelishman @coveralls