Skip to content

Avoid exception in Target.has_calibration for instruction without properties (backport #12526) #12527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

Avoid exception in Target.has_calibration for instruction without properties (backport #12526) #12527

merged 1 commit into from
Jun 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 7, 2024

Summary

Avoid exception in Target.has_calibration for instruction without properties

Details and comments

Target.add_instruction allows passing None in place of an InstructionProperties instance. In this case, there will be no _calibration attribute, so the getattr call properties needs to provide a default value, as done in this change.

Closes #12525

This is an automatic backport of pull request #12526 done by [Mergify](https://mergify.com).

@wshanks @mergify
Avoid exception in Target.has_calibration for instruction without p…
def5be8 
…roperties (#12526)

`Target.add_instruction` allows passing `None` in place of an
`InstructionProperties` instance. In this case, there will be no
`_calibration` attribute, so the `getattr` call properties needs to
provide a default value.

(cherry picked from commit 72f09ad)
@mergify mergify bot requested a review from a team as a code owner June 7, 2024 01:12
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Jun 7, 2024
@github-actions github-actions bot added this to the 1.1.1 milestone Jun 7, 2024
@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9410065617

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.006%) to 89.619%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.2%
crates/qasm2/src/lex.rs 3 92.62%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 9407129205: -0.006%
Covered Lines: 62252
Relevant Lines: 69463
💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Jun 7, 2024
Merged via the queue into stable/1.1 with commit c9095ba Jun 7, 2024
@mergify mergify bot deleted the mergify/bp/stable/1.1/pr-12526 branch June 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@qiskit-bot @coveralls @ElePT @wshanks