Avoid exception in Target.has_calibration for instruction without properties
#12526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties `Target.add_instruction` allows passing `None` in place of an `InstructionProperties` instance. In this case, there will be no `_calibration` attribute, so the `getattr` call properties needs to provide a default value.
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 9408550043Details
💛 - Coveralls |
mtreinish
approved these changes
Jun 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
…roperties (#12526) (#12527) `Target.add_instruction` allows passing `None` in place of an `InstructionProperties` instance. In this case, there will be no `_calibration` attribute, so the `getattr` call properties needs to provide a default value. (cherry picked from commit 72f09ad) Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
…roperties (Qiskit#12526) `Target.add_instruction` allows passing `None` in place of an `InstructionProperties` instance. In this case, there will be no `_calibration` attribute, so the `getattr` call properties needs to provide a default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid exception in
Target.has_calibrationfor instruction without propertiesDetails and comments
Target.add_instructionallows passingNonein place of anInstructionPropertiesinstance. In this case, there will be no_calibrationattribute, so thegetattrcall properties needs to provide a default value, as done in this change.Closes #12525