Fix pickling of NLayout
#12298
Merged
Fix pickling of NLayout
#12298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the module of this was set incorrectly (stemming from its move in Qiskitgh-9064), at which point the `__getstate__`/`__setstate__` pickling wouldn't work correctly any more. Also, however, there was no `__getnewargs__` and `new` didn't have a zero-argument form, so this wouldn't have worked either.
|
One or more of the the following people are requested to review this:
|
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
Pull Request Test Coverage Report for Build 8836685971Details
💛 - Coveralls |
mtreinish
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
LGTM, this is a straightforward fix. Although I assume we're never actually pickling/deepcopying nlayout objects I think the only place we're using them are inside the .run() methods for the sabre passes (and maybe stochastic swap) which won't pass a process boundary or anything so I'm not sure this comes up. I'm not sure why/when we added the __getstate__ and __setstate__ to the pyclass (looking at the code I suspect I'm responsible) but if we have the hook points defined we should make sure they work.
| @@ -91,7 +91,7 @@ impl VirtualQubit { | |||
| /// physical qubit index on the coupling graph. | |||
| /// logical_qubits (int): The number of logical qubits in the layout | |||
| /// physical_qubits (int): The number of physical qubits in the layout | |||
| #[pyclass(module = "qiskit._accelerate.stochastic_swap")] | |||
| #[pyclass(module = "qiskit._accelerate.nlayout")] | |||
There was a problem hiding this comment.
I wonder how many of these mistakes we've had after the multiple code refactors. It only will come up if we actually pickle an object though.
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Previously the module of this was set incorrectly (stemming from its move in gh-9064), at which point the `__getstate__`/`__setstate__` pickling wouldn't work correctly any more. Also, however, there was no `__getnewargs__` and `new` didn't have a zero-argument form, so this wouldn't have worked either. (cherry picked from commit 136548c) # Conflicts: # test/python/transpiler/test_layout.py
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Previously the module of this was set incorrectly (stemming from its move in gh-9064), at which point the `__getstate__`/`__setstate__` pickling wouldn't work correctly any more. Also, however, there was no `__getnewargs__` and `new` didn't have a zero-argument form, so this wouldn't have worked either. (cherry picked from commit 136548c)
jakelishman
added a commit
that referenced
this pull request
Apr 25, 2024
Previously the module of this was set incorrectly (stemming from its move in gh-9064), at which point the `__getstate__`/`__setstate__` pickling wouldn't work correctly any more. Also, however, there was no `__getnewargs__` and `new` didn't have a zero-argument form, so this wouldn't have worked either.
jakelishman
added a commit
that referenced
this pull request
Apr 25, 2024
Previously the module of this was set incorrectly (stemming from its move in gh-9064), at which point the `__getstate__`/`__setstate__` pickling wouldn't work correctly any more. Also, however, there was no `__getnewargs__` and `new` didn't have a zero-argument form, so this wouldn't have worked either.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Fix pickling of `NLayout` (#12298) Previously the module of this was set incorrectly (stemming from its move in gh-9064), at which point the `__getstate__`/`__setstate__` pickling wouldn't work correctly any more. Also, however, there was no `__getnewargs__` and `new` didn't have a zero-argument form, so this wouldn't have worked either. (cherry picked from commit 136548c) * Switch back to PyO3 0.20 --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Fix pickling of `NLayout` (#12298) Previously the module of this was set incorrectly (stemming from its move in gh-9064), at which point the `__getstate__`/`__setstate__` pickling wouldn't work correctly any more. Also, however, there was no `__getnewargs__` and `new` didn't have a zero-argument form, so this wouldn't have worked either. * Switch back to PyO3 0.20 --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously the module of this was set incorrectly (stemming from its move in gh-9064), at which point the
__getstate__/__setstate__pickling wouldn't work correctly any more. Also, however, there was no__getnewargs__andnewdidn't have a zero-argument form, so this wouldn't have worked either.Details and comments
No changelog because this is a private class, and it doesn't actually seem to be causing us problems.