Skip to content

Re-implement XXDecomposer in Rust #12105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Re-implement XXDecomposer in Rust #12105

wants to merge 8 commits into from

Conversation

jlapeyre
Copy link
Contributor

@jlapeyre jlapeyre commented Mar 30, 2024 •
edited by 1ucian0
Loading

Fixes #12005

This will be a translation to Rust of the Python version of the class XXDecomposer and supporting code.

@coveralls
Copy link

coveralls commented Mar 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11045266069

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 609 (1.48%) changed or added relevant lines in 10 files are covered.
  • 463 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.7%) to 88.108%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/accelerate/src/xx_decompose/utilities.rs 0 14 0.0%
crates/accelerate/src/xx_decompose/embodiments.rs 0 18 0.0%
crates/accelerate/src/gates.rs 4 29 13.79%
crates/accelerate/src/xx_decompose/decomposer.rs 0 33 0.0%
crates/accelerate/src/xx_decompose/weyl.rs 0 50 0.0%
crates/accelerate/src/xx_decompose/types.rs 0 89 0.0%
crates/accelerate/src/xx_decompose/polytopes.rs 0 110 0.0%
crates/accelerate/src/xx_decompose/paths.rs 0 119 0.0%
crates/accelerate/src/xx_decompose/circuits.rs 0 142 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit/pulse/instructions/directives.py 1 97.22%
crates/qasm2/src/expr.rs 1 94.02%
qiskit/pulse/transforms/alignments.py 1 96.45%
qiskit/qasm3/init.py 1 95.0%
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 1 95.45%
qiskit/circuit/library/pauli_evolution.py 2 96.15%
qiskit/primitives/containers/data_bin.py 2 96.36%
qiskit/quantum_info/operators/symplectic/sparse_pauli_op.py 3 93.98%
crates/qasm2/src/lex.rs 3 91.98%
qiskit/qasm2/parse.py 6 96.7%
Totals Coverage Status
Change from base Build 10912201268: -0.7%
Covered Lines: 73810
Relevant Lines: 83772
💛 - Coveralls

@jakelishman jakelishman mentioned this pull request Apr 4, 2024
Merged
@1ucian0 1ucian0 added the Rust This PR or issue is related to Rust code in the repository label Jun 11, 2024
@jlapeyre jlapeyre changed the title Re-implement XXDecomposer is Rust Re-implement XXDecomposer in Rust Sep 9, 2024
@jlapeyre jlapeyre force-pushed the xx-decomposer-rust branch 4 times, most recently from caa1a2d to 97c561e Compare September 11, 2024 00:34
@jlapeyre
Add strucures and check compiles
2846750
@jlapeyre
Ok this one compiles
c8e585c 
I have been observing a small number of sizes of array-like data. So I am
trying to make these Array s i.e. with static size. But this is difficult.
I plan to replace these with Vec. This commit starts this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Rust This PR or issue is related to Rust code in the repository synthesis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port XXDecomposer to Rust
4 participants
@jlapeyre @coveralls @1ucian0 @ShellyGarion