Skip to content

Unskipping the test: test.python.transpiler.test_layout_transformation.TestLayoutTransformation.test_full_connected_coupling_map #11766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

Unskipping the test: test.python.transpiler.test_layout_transformation.TestLayoutTransformation.test_full_connected_coupling_map #11766

merged 1 commit into from
Feb 12, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Feb 11, 2024

#10001 marked test.python.transpiler.test_layout_transformation.TestLayoutTransformation.test_full_connected_coupling_map as skip because Qiskit/rustworkx#897 . Now rustworkx released the PR, the test can return

@1ucian0 1ucian0 added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Feb 11, 2024
@1ucian0 1ucian0 requested a review from a team as a code owner February 11, 2024 21:12
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7864711908

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 89.201%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 90.68%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 7837327418: -0.01%
Covered Lines: 58822
Relevant Lines: 65943
💛 - Coveralls

ElePT
ElePT approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes, so LGTM.

@ElePT ElePT added this pull request to the merge queue Feb 12, 2024
Merged via the queue into Qiskit:main with commit b79bd34 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1ucian0 @qiskit-bot @coveralls @ElePT