Remove ParametricPulse
#11281
Remove ParametricPulse
#11281
Conversation
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6928112990
💛 - Coveralls |
| ) -> "ParametricPulseShapes": | ||
| """Get Qobj name from the pulse class instance. | ||
|
|
||
| Args: | ||
| instance: Symbolic or ParametricPulse class. |
There was a problem hiding this comment.
The references to library.parametric_pulses below should be removed.
|
@wshanks @nkanazawa1989 |
| @@ -257,8 +256,6 @@ def _build_waveform(self): | |||
| for command in commands: | |||
| duration = command.duration | |||
| tf = min(time + duration, self.tf) | |||
| if isinstance(command, ParametricPulse): | |||
There was a problem hiding this comment.
Do we need to replace this with SymbolicPulse?
| def detail_title( | ||
| program: Union[pulse.Waveform, pulse.ParametricPulse, pulse.Schedule], device: DrawerBackendInfo | ||
| ) -> str: | ||
| def detail_title(program: Union[pulse.Waveform, pulse.Schedule], device: DrawerBackendInfo) -> str: |
|
|
||
| The ``ParametricPulse`` base class and pulse library were superseded by the | ||
| :class:`~qiskit.pulse.SymbolicPulse` class and pulse library, which provide | ||
| better performance and QPY support. All removed library pulses have a |
There was a problem hiding this comment.
I'm not sure if symbolic will provide better performance. Visualization is usually slow due to symbolic expression evaluation overhead.
|
@nkanazawa1989 following my previous comment, do you want to handle this here or on #11024? |
|
Close in favor of #11024 (can be reopened if another PR cannot meet 1.0 deadline) |
Summary
This PR removes the
ParametericPulsebase class and pulse library.Details and comments
The
ParametricPulselibrary has been superseded by theSymbolicPulselibrary which provides QPY support and some performance improvements. It is supposed to be deprecated in Qiskit 0.46 in #11279, and has been pending deprecation since Terra 0.22. This PR removes the base class and pulse library.