Preparations to update the default MPL drawer style to "iqx"
#10950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- iqx -> iqp - add test for clifford
Merged
|
One or more of the the following people are requested to review this:
|
1ucian0
reviewed
Oct 12, 2023
Comment on lines
+281
to
+288
| if style == "default": | ||
| warn( | ||
| 'The default matplotlib drawer scheme will be changed to "iqp" in a following release. ' | ||
| 'To silence this warning, specify the current default explicitly as style="clifford", ' | ||
| 'or the new default as style="iqp".', | ||
| category=FutureWarning, | ||
| stacklevel=2, | ||
| ) |
1ucian0
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue a
FutureWarningif the current default style in the matplotlib drawer is used, which can be silenced by explicitly setting the style.The current default (named
"default") is changed to"clifford", as the colors are determined by whether a gate is a Pauli, Clifford, or U1/2/3 gate, but the name is just a first suggestion and can be changed.Additionally, the style
"iqp"is supported, which is an alias of"iqx".Notes
Set as draft as the tests likely need some additional care, but I wanted to open this PR to get feedback on the approach.