Fix IQX color schemes #10941
Merged
Fix IQX color schemes #10941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6380973092
💛 - Coveralls |
ElePT
reviewed
Oct 4, 2023
Comment on lines
+106
to
115
| "#BAE6FF", | ||
| "#000000" | ||
| ], | ||
| "cp": [ | ||
| "#BAE6FF", | ||
| "#000000" | ||
| ], | ||
| "mcphase": [ | ||
| "#BAE6FF", | ||
| "#000000" |
There was a problem hiding this comment.
Could you remind us what the rules are for assigning colors to gates? This way it would be easier to understand the changes.
There was a problem hiding this comment.
I realized I can't add a comment to a JSON file, but it's sort of documented here:
, but that's not very solid since it's just an (unused) dictionary in some class. Let's do a follow-up PR to properly put the color schemes in the API docs for all the schemes, maybe as follow up to #10950.The IQX color scheme is coloring gates by how much of a superposition they can create on a state:
- classical gates (i.e. exist on a CPU): dark blue
- diagonal (or phase) gates: light blue
- hadamard: orange -- this is special as it creates equal superposition (IMO also SX should be orange then)
- rest: dark red
ElePT
approved these changes
Oct 6, 2023
rupeshknn
pushed a commit
to rupeshknn/qiskit
that referenced
this pull request
Oct 9, 2023
* fix diagonal gate colors * fix iqx-dark and iswap * add reno * update reference images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
iqxandiqx-darkcolor schemes for the matplotlib drawer.Details and comments
Some diagonal gates (CPhase, RZ, RZZ) and the iSwap gate were not correctly categorized. E.g. iSwap was shown as blue (diagonal gate) but it's not diagonal.
Todo: Update drawer reference files, but I'm failing to produce the correct ones locally, so I'm using the created images of the CI