Pin Numpy < 2 in requirements #10893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have compiled extensions that are built against the Numpy C API. The Numpy transition guide for developers of downstream packages[^1] encourages us to put in this pin until we have wheels built against the newer version, which is not expected to be fully ABI compatible (but extensions built against Numpy 2 _should_ work with older Numpys). Note that this won't prevent package managers from resolving _older_ versions of Qiskit (which don't have the pin) along with Numpy 2, but there's not a vast amount we can do about that now. [^1]: numpy/numpy#24300
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6277399015
💛 - Coveralls |
mtreinish
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
I think this is the right thing to do, considering we know we're not numpy 2.0 ready yet until we close #10889. That being said we don't actually have a build time dependency on numpy, the ffi is manually defined in rust-numpy and we build against that rust interface. If there are big breaking changes in the API though I expect rust-numpy will need to be updated so we can interoperate with it. Either way, leaving the cap in place proactively until we know for sure qiskit works with numpy 2.0 is prudent
|
Yeah, my hope is to be ready as soon after the release of the 2.0rc as possible, and to revert this pin as soon as we are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have compiled extensions that are built against the Numpy C API. The Numpy transition guide for developers of downstream packages1 encourages us to put in this pin until we have wheels built against the newer version, which is not expected to be fully ABI compatible (but extensions built against Numpy 2 should work with older Numpys).
Note that this won't prevent package managers from resolving older versions of Qiskit (which don't have the pin) along with Numpy 2, but there's not a vast amount we can do about that now.
Summary
Details and comments
Footnotes
https://github.com/numpy/numpy/issues/24300 ↩