Add UnitaryOverlap to the circuit library #10734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
reviewed
Sep 5, 2023
main change: check if circuits are unitary by checking if all operations are of type ``Gate``
…a into unitary-overlap
- do not allow U/V - allow setting parameter prefixes
jakelishman
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
In principle this looks fine to me now. It's better that the argument names have a more consistent way of linking to the (default) parameter names, rather than us using three separate U/V, circ1/circ2 and a/b pairs to refer to the same split throughout the code and the public interface.
I'm still of the opinion that these kinds of things should be helper functions and not subclasses of QuantumCircuit, but it's better that this new object is consistent with the rest of the circuit library. The _check_unitary helper is slightly overcautious (it will reject directives like Barrier, for example), but in lieu of us having a better model for parametric gates at the moment, it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
UnitaryOverlapcircuit to the circuit library that aids in the construction of applications such as machine learning and chemistry.This circuit returns the fidelity of states generated by two unitaries as the probability of being in the all-zeros state or, equivalently, the expectation value of the projector over the all-zeros state.
Details and comments