Skip to content

Remove deprecated x and z arguments to Pauli #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Aug 28, 2023

  • The arguments x, z and label to the initializer of .Pauli were removed, as deprecated in Qiskit Terra 0.17 (released on 2021-04-02).
  • Importing from qiskit.quantum_info.operators.pauli was deprecated in Qiskit Terra 0.21 (released on 2022-06-30) is now removed.

Related: #8070

@1ucian0 1ucian0 requested review from ikkoham and a team as code owners August 28, 2023 09:20
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham

@1ucian0 1ucian0 changed the title Remove deprecated code introduced in #8070 Remove deprecated code in #8070 Aug 28, 2023
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM these removals seem long overdue. Just one comment inline about the release notes.

Comment on lines 3 to 8
- |
The arguments ``x``, ``z`` and ``label`` to the initializer of
:class:`.Pauli` were removed, as deprecated in Qiskit Terra 0.17 (released on 2021-04-02).
- |
Importing from ``qiskit.quantum_info.operators.pauli`` was deprecated in Qiskit Terra 0.21
(released on 2022-06-30) is now removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both of these it would be good to document the alternative people should be using instead. It is really useful for users when reading the release notes (typically after something breaks) to see how they should update their code based on this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap! added in 9de7412

Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing. LGTM except for @mtreinish's comment.

@ikkoham ikkoham added Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Aug 30, 2023
@ikkoham ikkoham added this to the 0.45.0 milestone Aug 30, 2023
@jakelishman jakelishman changed the title Remove deprecated code in #8070 Remove deprecated x and z arguments to Pauli Sep 29, 2023
@jakelishman jakelishman added this pull request to the merge queue Sep 29, 2023
Merged via the queue into Qiskit:main with commit d365009 Sep 29, 2023
rupeshknn pushed a commit to rupeshknn/qiskit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants