-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove deprecated x
and z
arguments to Pauli
#10717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM these removals seem long overdue. Just one comment inline about the release notes.
- | | ||
The arguments ``x``, ``z`` and ``label`` to the initializer of | ||
:class:`.Pauli` were removed, as deprecated in Qiskit Terra 0.17 (released on 2021-04-02). | ||
- | | ||
Importing from ``qiskit.quantum_info.operators.pauli`` was deprecated in Qiskit Terra 0.21 | ||
(released on 2022-06-30) is now removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both of these it would be good to document the alternative people should be using instead. It is really useful for users when reading the release notes (typically after something breaks) to see how they should update their code based on this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap! added in 9de7412
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing. LGTM except for @mtreinish's comment.
x
and z
arguments to Pauli
* remove arg * black * reno
x
,z
andlabel
to the initializer of.Pauli
were removed, as deprecated in Qiskit Terra 0.17 (released on 2021-04-02).qiskit.quantum_info.operators.pauli
was deprecated in Qiskit Terra 0.21 (released on 2022-06-30) is now removed.Related: #8070