Skip to content

Typos flagged by the IBM Quantum Platform automatic spellchecker #10711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Aug 26, 2023

Conversation

abbycross
Copy link
Collaborator

Summary

As part of its build, IQP now has an auto-spellchecker, and it flagged several minor typos in the API refs that are surfaced in IQP from the Qiskit/qiskit repo. Fixing them in this PR; hope this is the best way to contribute this kind of fix!--feedback welcome!

Details and comments

🍎 "Low-hanging fruit" 🍎

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - these are definitely good to get fixed.

Most of what I'm getting from this is that we really don't know how to spell "overridden" haha. (I even typed it wrong in that sentence at first, as well...)

Co-authored-by: Jake Lishman <jake@binhbar.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5979641915

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 87.273%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
crates/qasm2/src/lex.rs 3 91.39%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 5978384848: 0.02%
Covered Lines: 74279
Relevant Lines: 85111

💛 - Coveralls

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is very helpful. And we appreciate it being one PR rather than 55 small PRs hahaha.

I will mark this as needs-cherrypick so that it gets backported to the 0.44 documentation.

This method typically yields better CX cost compared to the Aaronson-Gottesma method.
This method typically yields better CX cost compared to the Aaronson-Gottesman method.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other reviewers, search results suggest it indeed should be Gottesman but FYI this one is not as obvious.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lucked out that I have heard this name bandied about in quantum contexts so I had a pretty high degree of confidence on it 🤣thanks for looking so closely @Eric-Arellano !

@Eric-Arellano Eric-Arellano added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Aug 25, 2023
@Eric-Arellano Eric-Arellano added this to the 0.25.2 milestone Aug 25, 2023
@abbycross abbycross marked this pull request as ready for review August 26, 2023 12:01
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Eric-Arellano
  • @javabster
  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @mtreinish
  • @nkanazawa1989
  • @t-imamichi

@jakelishman jakelishman added this pull request to the merge queue Aug 26, 2023
Merged via the queue into Qiskit:main with commit cb4da68 Aug 26, 2023
mergify bot pushed a commit that referenced this pull request Aug 26, 2023
)

* typo

* typos

* typos

* typo

* typo

* typo

* typo

* typos

* typos

* typo

* typo

* typos

* typos

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typos

* typo

* typo

* typo

* typo

* typo

* typo

* rst!!!!!

Co-authored-by: Jake Lishman <jake@binhbar.com>

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
(cherry picked from commit cb4da68)
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2023
) (#10713)

* typo

* typos

* typos

* typo

* typo

* typo

* typo

* typos

* typos

* typo

* typo

* typos

* typos

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typos

* typo

* typo

* typo

* typo

* typo

* typo

* rst!!!!!

Co-authored-by: Jake Lishman <jake@binhbar.com>

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
(cherry picked from commit cb4da68)

Co-authored-by: abbycross <across@us.ibm.com>
@abbycross abbycross deleted the typos branch August 27, 2023 20:54
mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Sep 1, 2023
github-merge-queue bot pushed a commit that referenced this pull request Sep 1, 2023
* Revert "Revert to one release notes file (#10639)"

The change to the release notes organization is only needed for the
stable/0.25 branch longer term. Moving forward we'll have a different
release notes strategy likely using the reno sphinx extension directly.
In the short term this reverts to the previous state prior to #10639 as
while #10639 was necessary for getting 0.25.1 released it did turn off
our CI coverage testing that release notes would be built. Restoring
this is important so we know from CI whether a change to the release
notes works as part of the docs build.

This reverts commit 0388d54.

* Sync release notes from 0.25.1

* Apply typo fix from #10711
SameerD-phys pushed a commit to SameerD-phys/qiskit-terra that referenced this pull request Sep 7, 2023
…kit#10711)

* typo

* typos

* typos

* typo

* typo

* typo

* typo

* typos

* typos

* typo

* typo

* typos

* typos

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typo

* typos

* typo

* typo

* typo

* typo

* typo

* typo

* rst!!!!!

Co-authored-by: Jake Lishman <jake@binhbar.com>

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants