-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Removal of deprecated property num_ancilla_qubits #10793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ations class removed function and deprecate_func from polynomial_pauli_rotations.py added release note with upgrade notice
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for taking care of this. Just one small comment on the release note syntax. Also thanks for doing the terra 0.16 -> qiskit 0.23 conversion. I would have totally forgotten about that.
- | | ||
The property ``num_ancilla_qubits`` from the class :class:`~qiskit.circuit.library.arithmetic.PolynomialPauliRotations` | ||
has been removed, as deprecated in Qiskit 0.23.0. | ||
Instead, use the property :attr:`~num_ancillas`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think sphinx will resolve this correctly. You probably need to give it a bit more context on the reference. Something like this:
Instead, use the property :attr:`~num_ancillas`. | |
Instead, use the property :attr:`.PolynomialPauliRotations.num_ancillas`. |
should work it will also make the text read PolynomialPauliRotations.num_ancillas
instead of just num_ancillas
releasenotes/notes/num-ancilla-qubits-deprecation-d616c3fc24250d22.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick updates.
Resolves #10743
This PR removes the code associated with the property
num_ancilla_qubits
in thePolynomialPauliRotations
classTo-Do: