-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove code deprecated in 0.15 #10779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_multivector, plot_state_city, plot_state_paulivec, and plot_state_qsphere. Removed scheduler.utils as functions were moved to pulse/macros and pulse/utils
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
Use |
Linting issues fixed and release note added! Also removed unused reference to the depreciation decorator in state_visualizations.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of #10742 Kyle!
For the next time, it is usual etiquete not to work on issues that are assigned to somebody else.
However, this PR makes the trick and push it over the line very quickly. I left a small comment on the release note, to keep it closer to our usual way to inform about removed code. Have a look and let me know your opinion.
releasenotes/notes/remove_depreciated_0.15_code-ee5c7d343e310888.yaml
Outdated
Show resolved
Hide resolved
Hi @unit0113 , do you mind have a look to the reno comment and to the CLA signing? |
ping @unit0113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged my suggestion so it can move on. Let's merge it!
Changelog: Removal
Summary
Fixes #10742
Removed deprecated references to Rho in plot_state_hinton, plot_bloch_multivector, plot_state_city, plot_state_paulivec, and plot_state_qsphere.
Removed scheduler.utils as all contained functions were moved to pulse/macros and pulse/utils.
Details and comments
As of version 0.15, keyword argument Rho was depreciated in favor of positional argument state. Depreciated references to Rho were removed from the state visualizations plot_state_hinton, plot_bloch_multivector, plot_state_city, plot_state_paulivec, and plot_state_qsphere. Additionally, 0.15 moved the format_meas_map, measure, and measure_all functions from scheduler/utils to pulse/macros and pulse/utils. The scheduler/utils.py file no longer contained any non-depreciated functionality and was removed.