Skip to content

Conversation

unit0113
Copy link
Contributor

@unit0113 unit0113 commented Sep 5, 2023

Changelog: Removal

Summary

Fixes #10742

Removed deprecated references to Rho in plot_state_hinton, plot_bloch_multivector, plot_state_city, plot_state_paulivec, and plot_state_qsphere.

Removed scheduler.utils as all contained functions were moved to pulse/macros and pulse/utils.

Details and comments

As of version 0.15, keyword argument Rho was depreciated in favor of positional argument state. Depreciated references to Rho were removed from the state visualizations plot_state_hinton, plot_bloch_multivector, plot_state_city, plot_state_paulivec, and plot_state_qsphere. Additionally, 0.15 moved the format_meas_map, measure, and measure_all functions from scheduler/utils to pulse/macros and pulse/utils. The scheduler/utils.py file no longer contained any non-depreciated functionality and was removed.

…_multivector, plot_state_city, plot_state_paulivec, and plot_state_qsphere. Removed scheduler.utils as functions were moved to pulse/macros and pulse/utils
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 5, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Raghav-Bell
Copy link
Contributor

Raghav-Bell commented Sep 6, 2023

Use tox -elint to run & fix linting tests locally, also add a release note. For detailed instructions refer to Contribution guide

@unit0113
Copy link
Contributor Author

unit0113 commented Sep 9, 2023

Linting issues fixed and release note added! Also removed unused reference to the depreciation decorator in state_visualizations.py

@1ucian0 1ucian0 changed the title Fixes issue 10742 Remove code deprecated in 0.15 Sep 11, 2023
@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Sep 11, 2023
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of #10742 Kyle!

For the next time, it is usual etiquete not to work on issues that are assigned to somebody else.

However, this PR makes the trick and push it over the line very quickly. I left a small comment on the release note, to keep it closer to our usual way to inform about removed code. Have a look and let me know your opinion.

@1ucian0 1ucian0 self-assigned this Sep 11, 2023
@1ucian0 1ucian0 added this to the 0.45.0 milestone Sep 11, 2023
@1ucian0
Copy link
Member

1ucian0 commented Sep 20, 2023

Hi @unit0113 , do you mind have a look to the reno comment and to the CLA signing?

@1ucian0
Copy link
Member

1ucian0 commented Sep 22, 2023

ping @unit0113

1ucian0
1ucian0 previously approved these changes Oct 9, 2023
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged my suggestion so it can move on. Let's merge it!

@1ucian0 1ucian0 added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2023
@1ucian0 1ucian0 added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2023
@jakelishman jakelishman added this pull request to the merge queue Oct 10, 2023
Merged via the queue into Qiskit:main with commit 023569b Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove code deprecated in 0.15 (released on August 06, 2020)
6 participants