Skip to content

Allow empty list default initialization for SparsePauliOp #10765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 12, 2023
Merged

Allow empty list default initialization for SparsePauliOp #10765

merged 16 commits into from
Sep 12, 2023

Conversation

SimoneGasperini
Copy link
Contributor

Original PR #10201.
Fix issue #10159.

SimoneGasperini and others added 15 commits June 4, 2023 18:24
@SimoneGasperini
Allow empty list default initialization of SparsePauliOp.from_list an…
bf53410 
…d SparsePauliOp.from_sparse_list
@SimoneGasperini
Fix empty iterable comparison in SparsePauliOp list initialization
85fcbfb
@SimoneGasperini
Fix default arguments, internal checks, and error messages
2bb3f70
@SimoneGasperini
Merge branch 'main' into sparsepauliop_default_init
487b9d6
@SimoneGasperini
Add unit tests for SparsePauliOp empty iterable initialization
bddcda4
@SimoneGasperini
Merge branch 'main' into sparsepauliop_default_init
90f5ffa
@SimoneGasperini
Merge branch 'main' into sparsepauliop_default_init
bde70da
@SimoneGasperini
Merge branch 'main' into sparsepauliop_default_init
63bd59f
@SimoneGasperini
Merge branch 'Qiskit:main' into sparsepauliop_default_init
bd12e11
@SimoneGasperini
Fix missing argument and linting errors
2a60e07
@SimoneGasperini
Merge branch 'main' into sparsepauliop_default_init
420742d
@SimoneGasperini
Resolve minor changes requested by @ikkoham review
b3e8f08
@SimoneGasperini
Merge branch 'main' into sparsepauliop_default_init
5ee209f
@SimoneGasperini
Add release note with reference to issue #10159
1dfed3c
@SimoneGasperini @jakelishman
Edit release note as suggested by @jakelishman
3cd7cc0 
Co-authored-by: Jake Lishman <jake@binhbar.com>
@SimoneGasperini SimoneGasperini requested review from ikkoham and a team as code owners September 3, 2023 14:56
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 3, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham

jakelishman
jakelishman approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same PR that I previously approved in #10201, so I'm still happy with it. Julien told me privately and commented on the other PR that his issue was resolved. @ikkoham: could you make sure you're happy with this, and tag it for merge if so?

@jakelishman jakelishman added Changelog: New Feature Include in the "Added" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Sep 4, 2023
@jakelishman
Copy link
Member

I've just pinged @ikkoham internally about this PR - I'm keen for it not to get forgotten. If he's not able to look by the end of the week, I'll just tag it for merge, because as I understand it, it's already addressed his previous comments.

ikkoham
ikkoham approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late. LGTM!

@ikkoham ikkoham added this pull request to the merge queue Sep 12, 2023
Merged via the queue into Qiskit:main with commit 7d17e68 Sep 12, 2023
@SimoneGasperini SimoneGasperini deleted the sparsepauliop_default_init branch September 12, 2023 15:27
@kevinsung kevinsung mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

+1 more reviewer

@ikkoham ikkoham ikkoham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Changelog: New Feature Include in the "Added" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
Contributor Monitoring
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimoneGasperini @qiskit-bot @jakelishman @ikkoham