Remove workaround for abi3 BigUint -> Python int conversio #10683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#10120 we moved to using the Python stable C API for the qiskit binaries we build. In that PR we encountered a limitation with PyO3 at the time when using abi3 it was unable to convert a BigUInt into a Python int directly. To workaround this we side stepped the issue by generating a string representation of the integer converting that to python and then having python go from a string to a int. This has some performance penalty and also prevented parallelism because a GIL handle was needed to do the conversion. In PyO3 0.19.1 this limitation was fixed and the library can handle the conversion directly now with abi3 and this commit restores the code that existed in the marginalization module prior to Qiskit#10120.
|
One or more of the the following people are requested to review this:
|
Eric-Arellano
approved these changes
Aug 21, 2023
Pull Request Test Coverage Report for Build 5932064108
💛 - Coveralls |
jakelishman
approved these changes
Aug 22, 2023
SameerD-phys
pushed a commit
to SameerD-phys/qiskit-terra
that referenced
this pull request
Sep 7, 2023
) In Qiskit#10120 we moved to using the Python stable C API for the qiskit binaries we build. In that PR we encountered a limitation with PyO3 at the time when using abi3 it was unable to convert a BigUInt into a Python int directly. To workaround this we side stepped the issue by generating a string representation of the integer converting that to python and then having python go from a string to a int. This has some performance penalty and also prevented parallelism because a GIL handle was needed to do the conversion. In PyO3 0.19.1 this limitation was fixed and the library can handle the conversion directly now with abi3 and this commit restores the code that existed in the marginalization module prior to Qiskit#10120.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #10120 we moved to using the Python stable C API for the qiskit binaries we build. In that PR we encountered a limitation with PyO3 at the time when using abi3 it was unable to convert a BigUInt into a Python int directly. To workaround this we side stepped the issue by generating a string representation of the integer converting that to python and then having python go from a string to a int. This has some performance penalty and also prevented parallelism because a GIL handle was needed to do the conversion. In PyO3 0.19.1 this limitation was fixed and the library can handle the conversion directly now with abi3 and this commit restores the code that existed in the marginalization module prior to #10120.
Details and comments