Skip to content

Negative feature #10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Negative feature #10669

wants to merge 4 commits into from

Conversation

SameerD-phys
Copy link
Contributor

Summary

Fixed a few errors in code, modified the release note and modified test.parameters.py to illustrate how to use the feature.

Details and comments

@SameerD-phys SameerD-phys requested a review from a team as a code owner August 18, 2023 17:55
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Aug 18, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sameer Dambal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sameer Dambal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SameerD-phys SameerD-phys mentioned this pull request Aug 18, 2023
Merged
@Raghav-Bell
Copy link
Contributor

Raghav-Bell commented Aug 22, 2023 •
edited
Loading

This PR is same implementation of #10571 & it will fix #10360 . @SamD-1998 Please don't repeat PRs. Maintainer should close one PR .

@wshanks
Copy link
Contributor

wshanks commented Aug 23, 2023

Let's keep the original pull request. I pushed the two new commits added here to the branch used for #10571. @SamD-1998 you can push additional changes to your negative_feature_10360 branch. If you need help with that, we can try to help, but it depends on how you are using git (command line, or integrated into VS Code or some other editor, or through a GUI git tool).

@wshanks wshanks closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Contributor Monitoring
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SameerD-phys @qiskit-bot @CLAassistant @Raghav-Bell @wshanks