Revert "Revert to one release notes file (#10639)" #10656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to the release notes organization is only needed for the stable/0.25 branch longer term. Moving forward we'll have a different release notes strategy likely using the reno sphinx extension directly. In the short term this reverts to the previous state prior to Qiskit#10639 as while Qiskit#10639 was necessary for getting 0.25.1 released it did turn off our CI coverage testing that release notes would be built. Restoring this is important so we know from CI whether a change to the release notes works as part of the docs build. This reverts commit 0388d54.
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5896437030
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5943633889
💛 - Coveralls |
Eric-Arellano
previously approved these changes
Aug 23, 2023
Eric-Arellano
approved these changes
Sep 1, 2023
jakelishman
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The change to the release notes organization is only needed for the stable/0.25 branch longer term. Moving forward we'll have a different release notes strategy likely using the reno sphinx extension directly. In the short term this reverts to the previous state prior to #10639 as while #10639 was necessary for getting 0.25.1 released it did turn off our CI coverage testing that release notes would be built. Restoring this is important so we know from CI whether a change to the release notes works as part of the docs build.
Details and comments
This reverts commit 0388d54.