Add full Expr support to StochasticSwap
#10506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for `switch` statements. This commit also adds some final tests of the pass.
|
One or more of the the following people are requested to review this:
|
mtreinish
approved these changes
Jul 26, 2023
Pull Request Test Coverage Report for Build 5671996471
💛 - Coveralls |
|
Yeah, I turned it up while writing full integration tests. I need to write a similar PR for testing Sabre (a minor bug in all switch handling), and then that's everything working. I'll try and do it late this evening. |
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for `switch` statements. This commit also adds some final tests of the pass. (cherry picked from commit 7af335e)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for `switch` statements. This commit also adds some final tests of the pass. (cherry picked from commit 7af335e) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was mostly already there (and why I had missed problems when testing before), the missing piece was just for
switchstatements. This commit also adds some final tests of the pass.Details and comments
Changelog from #10331.