Add Expr support to ControlFlowOp representation
#10358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5552067812
💛 - Coveralls |
cdc231b to
d0a2bea
Compare
kevinhartman
previously approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Very straightforward. These changes include #10332, so once that merges, this one is good to go too (after a rebase/merge).
I like how you were able to reuse a lot of the existing testing, and the integration points to enable expressions in the conditions and switch target are a lot more minimal than I was expecting!
This commit allows `IfElseOp` and `WhileLoopOp` to have a `condition` that is an `Expr` typed `Bool()`, and `SwitchCaseOp` to have a `target` that is an `Expr`. It does not fully add support to resolving these new allowed values into the control-flow builder interface (that will come later).
d0a2bea to
88595a5
Compare
|
Now rebased on top of |
kevinhartman
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit allows
IfElseOpandWhileLoopOpto have aconditionthat is anExprtypedBool(), andSwitchCaseOpto have atargetthat is anExpr. It does not fully add support to resolving these new allowed values into the control-flow builder interface (that will come later).Details and comments
Close #10224.
Depends on #10332. Same consideration about release note.
Originally I was doing the control-flow builder interface as part of this commit as well since there's very little additional work needed to make that work. In practice, though, being able to test the builder interface requires a bunch of the
DAGCircuit-related bits to be working as well, so I've split it off.