Skip to content

Because SymEngine 0.10, undoing 8456 #8734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Because SymEngine 0.10, undoing 8456 #8734

wants to merge 13 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Sep 13, 2022 •
edited
Loading

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added the on hold Can not fix yet label Sep 13, 2022
@nkanazawa1989
Copy link
Contributor

Similar issue and #8232 is also waiting for symengine 0.10.

@1ucian0 1ucian0 changed the title [waiting for SymEngine 0.10] undoing 8456 Because SymEngine 0.10, undoing 8456 Mar 24, 2023
@1ucian0 1ucian0 added Changelog: None Do not include in changelog and removed on hold Can not fix yet labels Mar 24, 2023
@1ucian0 1ucian0 marked this pull request as ready for review March 24, 2023 20:46
@1ucian0 1ucian0 requested a review from a team as a code owner March 24, 2023 20:46
nkanazawa1989
nkanazawa1989 previously approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Finally we get symengine 0.10 :)

@ElePT ElePT mentioned this pull request Mar 27, 2023
Merged
Cryoris
Cryoris reviewed Mar 27, 2023
View reviewed changes
Cryoris
Cryoris reviewed Mar 27, 2023
View reviewed changes
@nkanazawa1989
Copy link
Contributor

An thoughts? @1ucian0
#9857 (review)

@1ucian0
Copy link
Member Author

1ucian0 commented Mar 28, 2023

on hold until we decide what to do with py37 support (see #9857 (review))

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4542506747

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 195 unchanged lines in 21 files lost coverage.
  • Overall coverage increased (+0.006%) to 85.344%
Files with Coverage Reduction New Missed Lines %
qiskit/algorithms/time_evolvers/variational/var_qite.py 1 94.74%
qiskit/circuit/add_control.py 1 97.2%
qiskit/circuit/library/arithmetic/adders/vbe_ripple_carry_adder.py 1 98.55%
qiskit/circuit/library/standard_gates/p.py 1 98.9%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 94.68%
qiskit/circuit/controlflow/control_flow.py 2 85.71%
qiskit/circuit/controlledgate.py 2 97.78%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
qiskit/circuit/gate.py 3 96.51%
qiskit/circuit/library/n_local/two_local.py 3 89.47%
Totals Coverage Status
Change from base Build 4541449265: 0.006%
Covered Lines: 67055
Relevant Lines: 78570
💛 - Coveralls

@1ucian0 1ucian0 added the on hold Can not fix yet label Mar 28, 2023
@1ucian0
Copy link
Member Author

1ucian0 commented Apr 1, 2023

symengine updated their wheels to have py37. So removing on hold

@1ucian0 1ucian0 removed the on hold Can not fix yet label Apr 1, 2023
@coveralls
Copy link

coveralls commented Aug 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6391429351

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 87.003%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
crates/qasm2/src/lex.rs 6 90.91%
crates/qasm2/src/parse.rs 18 96.67%
Totals Coverage Status
Change from base Build 6387639473: -0.01%
Covered Lines: 74145
Relevant Lines: 85221
💛 - Coveralls

@1ucian0 1ucian0 mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris left review comments

@nkanazawa1989 nkanazawa1989 nkanazawa1989 left review comments

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1ucian0 @qiskit-bot @nkanazawa1989 @coveralls @Cryoris