Remove stale dev dependencies from requirements-dev.txt #8501
Conversation
In looking at the requirements-dev.txt list as part of Qiskit#8498 there were a few entries which were not needed and/or are being used anymore. This commit cleans those up and also removes an unused script for reporting ci failures. The report script has been completed supersceded by native comment actions in azure pipelines and github actions so we no longer need to manually call the github api to report CI failures on periodic jobs.
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2870244508
💛 - Coveralls |
| # Install setuptools-rust for building sdist | ||
| pip install -U -c constraints.txt setuptools-rust | ||
| python setup.py sdist |
There was a problem hiding this comment.
At some point we might want to replace this sort of thing with pip install build; python -mbuild --sdist to get full PEP-517-compatible sdist building (that would automatically isolate and install setuptools-rust from pyproject.toml), but it doesn't need to / shouldn't be in this PR.
requirements-dev.txt
Outdated
| @@ -1,4 +1,3 @@ | |||
| setuptools-rust | |||
There was a problem hiding this comment.
Just to check: is the reason for removing this just because it's specified in pyproject.toml as a build requirement?
There was a problem hiding this comment.
Yeah, exactly. We shouldn't need to have it in the requirements list because it's a build only dep and if we're using pip it will pull it from the pyproject.toml
Summary
In looking at the requirements-dev.txt list as part of #8498 there were
a few entries which were not needed and/or are being used anymore. This
commit cleans those up and also removes an unused script for reporting
ci failures. The report script has been completed supersceded by native
comment actions in azure pipelines and github actions so we no longer
need to manually call the github api to report CI failures on periodic
jobs.
Details and comments