Skip to content

Conversation

itoko
Copy link
Contributor

@itoko itoko commented Sep 30, 2021

Summary

Fix #7006 by tracking availability of clbits in scheduling passes

Details and comments

Previously, scheduling of circuits using clbits was not correct because availability of clbits was not considered in scheduling passes. This PR updates scheduling passes (ASAP, ALAP, AlignMeasures) so that they take clbits availability into accounts, assuming a simple I/O model where measure locks clbits to be written at its end and c_if locks clbits to be read at its beginning. It also assumes zero time for creg I/O operations since current backends do not report I/O latencies (how much time it takes for such an I/O operation on clbits).

@itoko itoko requested a review from a team as a code owner September 30, 2021 05:58
@itoko itoko added this to the 0.19 milestone Oct 6, 2021
@itoko itoko added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Oct 6, 2021
Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments from a first pass. Looks good so far.

kdk
kdk previously approved these changes Oct 14, 2021
Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates @itoko !

@kdk kdk added the automerge label Oct 14, 2021
kdk
kdk previously approved these changes Oct 14, 2021
@mergify mergify bot merged commit 120e893 into Qiskit:main Oct 19, 2021
@itoko itoko deleted the fix-7006 branch November 1, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALAP/ASAP scheduler produces incorrect delays for circuits with classically controlled gates
3 participants