Skip to content

Fixed diassembler for circuits containing single bit conditioned gates #6989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 16, 2021
Merged

Fixed diassembler for circuits containing single bit conditioned gates #6989

merged 9 commits into from
Sep 16, 2021

Conversation

TharrmashasthaPV
Copy link
Contributor

@TharrmashasthaPV TharrmashasthaPV commented Sep 8, 2021 •
edited
Loading

Summary

Fixes part of #6475 .

Details and comments

This is a follow up of #6018 . This PR fixes disassemble() function for circuits that contain gates with single bit conditionals. Two tests are also added.

@TharrmashasthaPV TharrmashasthaPV mentioned this pull request Sep 8, 2021
Open
11 tasks
@TharrmashasthaPV TharrmashasthaPV changed the title [WIP] Fixed diassembler for circuits containing single bit conditioning [WIP] Fixed diassembler for circuits containing single bit conditioned gates Sep 8, 2021
@TharrmashasthaPV TharrmashasthaPV marked this pull request as ready for review September 15, 2021 09:15
@TharrmashasthaPV TharrmashasthaPV requested a review from a team as a code owner September 15, 2021 09:15
@TharrmashasthaPV TharrmashasthaPV changed the title [WIP] Fixed diassembler for circuits containing single bit conditioned gates Fixed diassembler for circuits containing single bit conditioned gates Sep 15, 2021
1ucian0
1ucian0 reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@1ucian0 1ucian0 added automerge Changelog: None Do not include in changelog labels Sep 16, 2021
@mergify mergify bot merged commit d20866e into Qiskit:main Sep 16, 2021
@jakelishman jakelishman mentioned this pull request Nov 10, 2021
Merged
@kdk kdk added this to the 0.19 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.
3 participants
@TharrmashasthaPV @1ucian0 @kdk