Added LogicalExpressionOracle #5656
Conversation
Code review
| from qiskit.circuit import QuantumCircuit, QuantumRegister | ||
|
|
||
|
|
||
| class LogicalExpressionOracle(QuantumCircuit): |
There was a problem hiding this comment.
Shouldn't LogicalExpressionOracle be an Instruction?
There was a problem hiding this comment.
It should be a circuit, since it's going in the circuit library 🙂 also then it's directly compatible with the GroverOperator which takes a circuit as oracle
|
Do we need the the single-char expression input format? It seems trivial to write If so, maybe is better to extend Also, the DIMACS expression string is converted to a single-char expression string which is converted to a word expression string which parsed and converted to a tweedledum network. We could remove one step of this if we have no single-char expressions or if we just python parse directly. Even further, I think tweedledum has support for DIMACS expressions... @boschmitt ? |
|
Is there a "word-format" for xor? Or does this only exist for the char-format ( |
No XOR, but CNF does not have XOR neither, right? |
Yeah but the current |
|
Included in #5830. |
Summary
Added
LogicalExpressionOracleinto the circuit library which creates an oracle circuit from a logical expression like~x & (y | z). It also supports a string in the DIMACS format.Details and comments
This is an ongoing project from Qiskit/qiskit-aqua#1376.