Skip to content

Conversation

ajavadia
Copy link
Member

Summary

  • It was not possible to combine circuits that contained simulator extension instructions: load, save, snapshot, noise, wait. This PR fixes that by fixing the reapply method of those instructions.
  • Moved the tests for combining/extending circuits from test_quantumprogram.py to test_circuit_combine_extend.py.
  • Write new tests for testing combining/extending of circuits that contain extension instructions (e.g. barrier, snapshot, initialize). The latter was reported as a bug in Circuits obtained from initialize cannot be combined #433, and later fixed but with no tests.

Details and comments

atilag
atilag previously approved these changes Jun 11, 2018
@atilag atilag merged commit 9d84eb4 into Qiskit:master Jun 11, 2018
@ajavadia ajavadia deleted the fix/snapshot branch July 21, 2018 00:01
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
…it#556)

* Fix  for simulator extension instructions
* Adding tests for extending/combining circuits with init/barrier/snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants