Remove ProjectQ from qiskit-core #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ajavadia
reviewed
Jun 10, 2018
| with patch.object(path, 'exists', return_value=True, autospec=True),\ | ||
| patch.object(path, 'getsize', return_value=1000, autospec=True),\ | ||
| patch.object(qasm_simulator_projectq, 'CppSim', {}): |
There was a problem hiding this comment.
@delapuente can you please double check this to see if the intent of your tests are preserved if we remove ProjectQ simulator here?
ajavadia
previously approved these changes
Jun 10, 2018
jaygambetta
previously approved these changes
Jun 11, 2018
b37a5f4
diego-plan9
approved these changes
Jun 12, 2018
There was a problem hiding this comment.
Thanks @yaelbh , nice surgical work once again! I just removed a TODO that was made obsolete by the changes, and also solved the conflicts (taking the chance as well to sort some issues with the CHANGELOG that we did not include in the latest release) - it's looking good!
8 tasks
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Removed ProjectQ from qiskit-core. Will be available in a new repository qiskit-addon-projectq. * Updated CHANGELOG with the ProjectQ removal * Remove outdated TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since the ProjectQ simulator will be moved to a new repository qsikit-addon-projectq, this pull request removes it from qiskit-core.
Details and comments