Skip to content

Conversation

eendebakpt
Copy link
Contributor

The filename of the generated .png file is specified only relative and not found under windows.

@diego-plan9
Copy link
Member

Thanks @eendebakpt - can you take care of a small linting issue? This seems it will fix #477

@eendebakpt
Copy link
Contributor Author

@diego-plan9 Did an autopep8 on the modified file, that should fix the linting issue.

@diego-plan9
Copy link
Member

Thanks, @eendebakpt ! Actually seems the autopep8 was more thorough than ideal, and picked up a number of style checks that are recommended but not enforced by PEP8 - E226 ("missing whitespace around arithmetic operator") being the most noisy one. I have reverted those changes keeping only the one in the lines you introduced, for clarity, and I think we are good to go as soon as the CI pass. Thanks a lot! 🎉

@diego-plan9 diego-plan9 merged commit 975e551 into Qiskit:master Jun 7, 2018
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* fix issue with filename location on windows

* autopep8

* Revert autopep8 due to E225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants