Skip to content

Fixed Bug (#511): removed _modifiers call from reapply #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2018
Merged

Fixed Bug (#511): removed _modifiers call from reapply #534

merged 3 commits into from
Jun 5, 2018

Conversation

ismaila-at-za-ibm
Copy link
Contributor

Description

The _modifiers wrapper was calling invert because the invert flag was set. But this does another level of inverting which is not required. So we have removed it.

Motivation and Context

Fixes Bug #511

How Has This Been Tested?

Fixed the test case (apologies for it being wrong in the first place).

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [x ] All new and existing tests passed (only tested the affected test).

diego-plan9
diego-plan9 approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@diego-plan9 diego-plan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ismaila-at-za-ibm for the neat fix!

@diego-plan9 diego-plan9 merged commit 37f0209 into Qiskit:master Jun 5, 2018
@diego-plan9 diego-plan9 mentioned this pull request Jun 5, 2018
Closed
@ajavadia ajavadia mentioned this pull request Jun 16, 2018
Merged
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
@ismaila-at-za-ibm @diego-plan9
Fixed Bug (Qiskit#511): removed _modifiers call from reapply (Qiskit#534
33ba615 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diego-plan9 diego-plan9 diego-plan9 approved these changes

@ajavadia ajavadia Awaiting requested review from ajavadia

@atilag atilag Awaiting requested review from atilag

@ewinston ewinston Awaiting requested review from ewinston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismaila-at-za-ibm @diego-plan9