Fix hardcoded backend mapping tests #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
approved these changes
May 29, 2018
jaygambetta
approved these changes
May 30, 2018
diego-plan9
approved these changes
Jun 4, 2018
There was a problem hiding this comment.
Thanks, @nonhermitian ! We could probably apply a similar solution to other tests throughout the test suite, as indeed not having them rely on a specific backend (specially if they depend on the topology, which might be subject to change) as well.
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Fix hardcoded backend tests * make pylint happy * add class doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new mapper tests were hardcoded to the qx5, since that is where the tests failed, but the test should not actually rely on the backend being there.
Motivation and Context
Tests would fail if token did not have access to the qx5. Now a fake backend is passed with the qx5 coupling map, and minimal additional information for compiling to work.
How Has This Been Tested?
Tests modified and passing locally.
Screenshots (if appropriate):
Types of changes
Checklist: