Skip to content

Conversation

yaelbh
Copy link
Contributor

@yaelbh yaelbh commented May 28, 2018

Addressing Issue #425, I created a new repository for Sympy simulators. In that repository, I opened a pull request, parallel to this one:
https://github.com/QISKit/qiskit-core-backend-module-sympy/pull/1

Now back to the qiskit-sdk-py repository, this pull request removes Sympy simulators, while making sure that all thet remains in qiskit-sdk-py works properly.

Issue #425 contains more detailed information about what's planned both here and in the new repository.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yaelbh yaelbh requested a review from jaygambetta as a code owner May 28, 2018 11:00
jaygambetta
jaygambetta previously approved these changes Jun 1, 2018
@diego-plan9 diego-plan9 added this to the 0.5.x milestone Jun 6, 2018
@yaelbh yaelbh mentioned this pull request Jun 6, 2018
8 tasks
@diego-plan9 diego-plan9 changed the title [WIP] Create a new repository for Sympy simulators Remove Sympy simulators for moving to new repository Jun 6, 2018
@diego-plan9
Copy link
Member

Thanks for the thorough removal of the sympy simulators, @yaelbh ! I am merging this PR already after discussion on yesterday's meeting, looking forward to the simulators finding a new home in the new repo soon 🎉

@diego-plan9 diego-plan9 merged commit ce8a73d into Qiskit:master Jun 6, 2018
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* Removed files that were copied to the new repository

* Completely removed all mentions of Sympy simulators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants