Skip to content

Changes on HoareOptimizer #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 12, 2021
Merged

Changes on HoareOptimizer #5135

merged 8 commits into from
Jun 12, 2021

Conversation

georgios-ts
Copy link
Contributor

Summary

Changes on HoareOptimizer. Resolves #4981.

Details and comments

This PR introduces the following changes on HoareOptimizer.

  • Fixes triviality check condition for CZGate, CU1Gate, MCU1Gate.
    These gates act trivially (up to global phase) iff the clause or together with previous conditions is unsatisfiable.

  • Removes 'always trivial' condition from CRZGate.

  • Catches CircuitError for instructions with no inverse.
    For example, the following code would previously raise an error.

qc = QuantumCircuit(1)
qc.x(0)
qc.measure_all()

pm = PassManager()
pm.append(HoareOptimizer(size=10))
circ = pm.run(qc)
  • Adds another optmization step by removing the control from a Controlled - U (and applies U directly on target qubits) iff all control qubits are in definite |1> state.

@georgios-ts georgios-ts requested a review from a team as a code owner September 26, 2020 13:41
georgios-ts and others added 2 commits September 26, 2020 16:48
@georgios-ts
lint
0fe5c47
@1ucian0
Some docstring rewriting
126b955 
Co-authored-by: Abby Mitchell <abby.mitchell@btinternet.com>
@1ucian0
Copy link
Member

1ucian0 commented Oct 9, 2020

While reviewing this PR with @javabster, we noticed that the qiskit/transpiler/passes/optimization/_gate_extension.py docstring was a bit twisted. @georgios-ts, hope you dont mind we pushed a change in this branch ( 126b955 ) with, what we think, is a better docstring.

1ucian0
1ucian0 reviewed Oct 16, 2020
View reviewed changes
@georgios-ts @1ucian0
Update test/python/transpiler/test_hoare_opt.py
1abaea3 
Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
1ucian0
1ucian0 reviewed Oct 16, 2020
View reviewed changes
@georgios-ts @1ucian0
Update qiskit/transpiler/passes/optimization/hoare_opt.py
6b31c4f 
Co-authored-by: Luciano Bello <luciano.bello@ibm.com>
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ajavadia
ajavadia previously approved these changes Jun 12, 2021
View reviewed changes
Copy link
Member

@ajavadia ajavadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, please also add a bugfix release note

@ajavadia ajavadia merged commit 1bae458 into Qiskit:main Jun 12, 2021
@jakelishman jakelishman mentioned this pull request Nov 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 left review comments

@ajavadia ajavadia ajavadia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HoareOptimizer does not handle CZ correctly
4 participants
@georgios-ts @1ucian0 @CLAassistant @ajavadia