Skip to content

MPL circuit drawer left align when the circuit is short #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 17, 2020
Merged

MPL circuit drawer left align when the circuit is short #5074

merged 12 commits into from
Sep 17, 2020

Conversation

abhobe
Copy link
Contributor

@abhobe abhobe commented Sep 16, 2020 •
edited
Loading

Summary

Details and comments

Much of the credit goes to @enavarro51 for helping me on this.

@abhobe abhobe requested review from maddy-tod, nonhermitian and a team as code owners September 16, 2020 01:36
@1ucian0 1ucian0 changed the title Fixing 2788 MPL circuit drawer left align when the circuit is short Sep 16, 2020
@abhobe
Copy link
Contributor Author

abhobe commented Sep 17, 2020

@1ucian0 Binder Tests Are Ready

1ucian0
1ucian0 reviewed Sep 17, 2020
View reviewed changes
@1ucian0
Copy link
Member

1ucian0 commented Sep 17, 2020

All the references were changed (see https://mybinder.org/v2/gh/abhobe/qiskit-terra/2788?urlpath=apps/test/ipynb/mpl_tester.ipynb) so updating in b86e7f4

1ucian0
1ucian0 previously approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@1ucian0 1ucian0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhobe
Copy link
Contributor Author

abhobe commented Sep 17, 2020

Will their need to be updates on documentation to match the new style of mpl?

@1ucian0
Copy link
Member

1ucian0 commented Sep 17, 2020

Will their need to be updates on documentation to match the new style of mpl?

It is generated independently. It will be updated in the next cycle.

@abhobe
Copy link
Contributor Author

abhobe commented Sep 17, 2020

Oh ok, I will see if I can help with that.

@1ucian0 1ucian0 dismissed their stale review September 17, 2020 21:10

hold on.. I need a deeper look

@mergify mergify bot merged commit 56a42ce into Qiskit:master Sep 17, 2020
@abhobe abhobe deleted the 2788 branch September 18, 2020 00:06
@1ucian0 1ucian0 removed the automerge label Sep 18, 2020
@enavarro51 enavarro51 mentioned this pull request Nov 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

@maddy-tod maddy-tod Awaiting requested review from maddy-tod

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gates are not left justified in mpl circuit drawer
2 participants
@abhobe @1ucian0