Add global phase to qobj in assembly #4822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the global phase circuit property to the experiment headers in the assembled qobj. Currently we do not pass the global phase to backends so simulators can not take it into account. The experiment header is used since it's a free form field for properties of the circuit that a backend can use if they want, but there are no requirements on it. With this in place it should enable Qiskit#4805 and Qiskit/qiskit-aer#847 to be fixed. Related to Qiskit#4805
6f4c1ac to
4a4d36b
Compare
ewinston
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds the global phase circuit property to the experiment
headers in the assembled qobj. Currently we do not pass the global phase
to backends so simulators can not take it into account. The experiment
header is used since it's a free form field for properties of the
circuit that a backend can use if they want, but there are no
requirements on it. With this in place it should enable #4805 and
Qiskit/qiskit-aer#847 to be fixed.
Details and comments
Related to #4805