Skip to content

Conversation

jaygambetta
Copy link
Member

@jaygambetta jaygambetta commented May 12, 2018

I would like to use full names

Schemas are still not used so no need to test.

@jaygambetta jaygambetta requested a review from ajavadia May 12, 2018 00:37
@dcmckayibm
Copy link
Member

I'm not sure you added the renamed ones

@jaygambetta jaygambetta requested a review from dcmckayibm May 12, 2018 01:24
@jaygambetta
Copy link
Member Author

jaygambetta commented May 12, 2018

should be fixed now

@ajavadia
Copy link
Member

for consistency, can we have all the examples be like XXX_example.json and all the schemas like YYY_schema.json.

Right now the schemas are ok, but the examples are a bit disorganized in name.

@jaygambetta
Copy link
Member Author

jaygambetta commented May 12, 2018

@ajavadia just for you, but what did i start :-)

ajavadia
ajavadia previously approved these changes May 12, 2018
@dcmckayibm
Copy link
Member

Should we change available to operational in backend_status_schema.json?

@jaygambetta jaygambetta requested a review from diego-plan9 May 13, 2018 00:31
Copy link
Member

@dcmckayibm dcmckayibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in backend_status_schema change available to operational and update the example.

@ajavadia ajavadia requested review from atilag and ewinston as code owners May 29, 2018 23:43
@jaygambetta
Copy link
Member Author

Thanks Ali

@ajavadia ajavadia merged commit f645b04 into Qiskit:master Jun 1, 2018
@jaygambetta jaygambetta deleted the schema branch June 5, 2018 10:03
lia-approves pushed a commit to edasgupta/qiskit-terra that referenced this pull request Jul 30, 2019
* fixing the names

* fixing the test for the schemas

* renaming for ali

* available -> operational
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants