Remove Backend primtive v1 dependent tests #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now there are tests that rely on the `BackendSampler`, `Sampler`, `Estimator` and `BackendEstimator` classes. These tests are testing the full path execution workflow with primitives for qiskit-algorithms and application modules with v1 implementations as input to these modules. However, these v1 primitive implementations are deprecated and will be removed in qiskit 2.0. This makes these test infeasible moving forward because qiskit-algorithms only supports the primitives v1 interface, so while there is a v2 interface available for the backend primitives in qiskit these can't be used with algorithms anymore. So this commit deletes the tests in questions to unblock the qiskit removal PR.
|
|
ElePT
reviewed
Feb 26, 2025
This was referenced Mar 5, 2025
|
This should be working now, I've got the ml tests running with the v2 statevector primitives instead of the v1 "reference" primitives, and removed the other instances of v1 usage. |
ElePT
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there are tests that rely on the
BackendSampler,Sampler,EstimatorandBackendEstimatorclasses. These tests are testing the full path execution workflow with primitives for qiskit-algorithms and application modules with v1 implementations as input to these modules. However, these v1 primitive implementations are deprecated and will be removed in qiskit 2.0. This makes these test infeasible moving forward because qiskit-algorithms only supports the primitives v1 interface, so while there is a v2 interface available for the backend primitives in qiskit these can't be used with algorithms anymore. So this commit deletes the tests in questions to unblock the qiskit removal PR.