This repository was archived by the owner on Aug 19, 2023. It is now read-only.
Add single-threaded versions of RB benchmarks. #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
suggested changes
Aug 8, 2019
There was a problem hiding this comment.
The idea behind this change LGTM, but I'm concerned about the environmental variable use here. Will the variable stick between runs of the benchmark? I think just to be safe we should add a teardown[1] method to both benchmark classes to make sure we unset the env variable (if it's set) after each benchmark execution.
[1] https://asv.readthedocs.io/en/stable/writing_benchmarks.html#setup-and-teardown-functions
7d2ddf2 to
5ae9b0f
Compare
|
@mtreinish did you and @kdk close on this. |
|
@jaygambetta @kdk and I were talking about this one the other day. There are some last minute changes he was working on before this is ready. |
mtreinish
approved these changes
Aug 15, 2019
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
…kage#396) * Add single-threaded versions of RB benchmarks. * Unset QISKIT_IN_PARALLEL env variable after RB benchmarks.
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
…kage#396) * Add single-threaded versions of RB benchmarks. * Unset QISKIT_IN_PARALLEL env variable after RB benchmarks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qiskit.transpilewill attempt to distribute circuits for transpilation across any available cores, generally reducing transpile times, but measuring single threaded performance can provide more reliable insight into how individual commits impact performance and will allow for measuring the benefit of parallel vs serial transpilation.This PR adds a single-threaded version to the RB benchmark, which currently transpiles in parallel, by hard coding the
QISKIT_IN_PARALLELenvironment variable.