This repository was archived by the owner on Aug 19, 2023. It is now read-only.
Avoid using FakeMelbourne from qiskit/test #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous update to the the quantum volume benchmarks the fake melbourne class from the terra tests was used instead of hardcoding the coupling map directly in the benchmark. However because this lives in the terra tests python namespace it has a depedency on a bunch of test requirements at import time (even though they're not used). This causes the benchmarks to fail in a production environment because they do not install the terra development/testing requirements in the venv used for testing. To avoid this failure, this commit removes the fake backend usage and switches to a hard coded coupling map which was just copied from the backend code. [1] [1] https://github.com/Qiskit/qiskit-terra/blob/master/qiskit/test/mock.py#L258-L260
ajavadia
approved these changes
May 24, 2019
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
…#301) In the previous update to the the quantum volume benchmarks the fake melbourne class from the terra tests was used instead of hardcoding the coupling map directly in the benchmark. However because this lives in the terra tests python namespace it has a depedency on a bunch of test requirements at import time (even though they're not used). This causes the benchmarks to fail in a production environment because they do not install the terra development/testing requirements in the venv used for testing. To avoid this failure, this commit removes the fake backend usage and switches to a hard coded coupling map which was just copied from the backend code. [1] [1] https://github.com/Qiskit/qiskit-terra/blob/master/qiskit/test/mock.py#L258-L260
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
…#301) In the previous update to the the quantum volume benchmarks the fake melbourne class from the terra tests was used instead of hardcoding the coupling map directly in the benchmark. However because this lives in the terra tests python namespace it has a depedency on a bunch of test requirements at import time (even though they're not used). This causes the benchmarks to fail in a production environment because they do not install the terra development/testing requirements in the venv used for testing. To avoid this failure, this commit removes the fake backend usage and switches to a hard coded coupling map which was just copied from the backend code. [1] [1] https://github.com/Qiskit/qiskit-terra/blob/master/qiskit/test/mock.py#L258-L260
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the previous update to the the quantum volume benchmarks the fake
melbourne class from the terra tests was used instead of hardcoding the
coupling map directly in the benchmark. However because this lives in
the terra tests python namespace it has a depedency on a bunch of test
requirements at import time (even though they're not used). This causes
the benchmarks to fail in a production environment because they do not
install the terra development/testing requirements in the venv used for
testing. To avoid this failure, this commit removes the fake backend
usage and switches to a hard coded coupling map which was just copied
from the backend code. [1]
Details and comments
[1] https://github.com/Qiskit/qiskit-terra/blob/master/qiskit/test/mock.py#L258-L260