Skip to content

Add new active_instance method #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 22, 2025
Merged

Add new active_instance method #2325

merged 6 commits into from
Jul 22, 2025

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jul 16, 2025 •
edited
Loading

Summary

Also un-deprecating the instance parameter in service.jobs() because we can repurpose it to filter by instance.

Details and comments

Fixes #2322

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Jul 16, 2025
ElePT
ElePT reviewed Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @kt474. The implementation looks good. Could you add unit tests too? (was there a IQP unit test for the instance parameter in jobs that we could repurpose?)

@ElePT ElePT added this to the 0.41.0 milestone Jul 17, 2025
@ElePT ElePT added the enhancement New feature or request label Jul 17, 2025
ElePT
ElePT reviewed Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Almost there. On the previous review I was unclear but I wanted to ask for an service.active_instance unit test too.

@kt474 kt474 requested a review from ElePT July 21, 2025 18:18
ElePT
ElePT approved these changes Jul 22, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again!

@ElePT ElePT added this pull request to the merge queue Jul 22, 2025
Merged via the queue into Qiskit:main with commit cacaec1 Jul 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog enhancement New feature or request
Projects
None yet
Milestone
0.41.0
Development

Successfully merging this pull request may close these issues.

Add an active_instance() method
2 participants
@kt474 @ElePT