Skip to content

Added a check to verify that observables don't contain projections #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2025
Merged

Added a check to verify that observables don't contain projections #2254

merged 4 commits into from
May 8, 2025

Conversation

yaelbh
Copy link
Collaborator

@yaelbh yaelbh commented May 7, 2025

Summary

Fixes #2250

Details and comments

  • This PR's code runs successfully with both Qiskit's main branch and stable branch.
  • I changed coefficients in the test to real numbers, because complex coefficients are not allowed, and trigger an exception.
  • Similarly, I changed the invalid letters in the test from J to 0, 1, +, -, l, r, because J is caught already early, by SparseObservable. The goal of the test is to verify that qiskit-ibm-runtime imposes further constraints than SparseObservable.

@yaelbh yaelbh requested review from ihincks and ElePT May 7, 2025 11:41
ElePT
ElePT reviewed May 7, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yaelbh, the PR looks good to me, I just left some minor release note suggestions and it should be good to go. I will try to include this in the upcoming 0.39 release to get the new validation out ASAP :)

@ElePT ElePT added this to the 0.39.0 milestone May 7, 2025
kt474 and others added 3 commits May 7, 2025 21:51
ElePT
ElePT approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue May 8, 2025
Merged via the queue into Qiskit:main with commit 428073e May 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

@ihincks ihincks Awaiting requested review from ihincks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.39.0
Development

Successfully merging this pull request may close these issues.

Validate observables to include only the letters I, X, Y, Z
3 participants
@yaelbh @ElePT @kt474