Fix session/batch type hint #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElePT
reviewed
Apr 22, 2025
There was a problem hiding this comment.
The change looks good! I added the backport potential label, and it made me realize that we hadn't discussed backports yet. I have a few questions:
- Is the process automatized or manual?
- What are curently the criteria to decide whether a bug fix should get backported?
- When does the package publish patch releases? (is there a regular schedule or is it rather need based)
Currently it's a manual process (maybe worth looking into mergify)
We don't have strict criteria for patch releases, it's mostly need based. It's worth discussing though, in the future we should have a more standardized process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backendis not optional and there is already an error raised if no backend is passed in so we should be able to just remove the incorrect type hint.Details and comments
Fixes #