Update parameters to accommodate with RZZ constraints #2126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left undone for now:
Other than that it's ready to play with. |
wshanks
reviewed
Jul 14, 2025
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
wshanks
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Approving now because I don't expect @ElePT to be available to give feedback soon and the code all seems good. We can have a follow up PR just to add the function to the public API at a later point and that should be easy to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves #2125 through a function that translates from pub to pub.
Only stared - work is still in progress.
Details and comments
In fact, in order not to have to bother with the different structures parameter values can have in pubs, at least for now we translate a pair of circuit and parameter values to another pair, and require the parameter values to be just a list of tuples. The order inside each tuple matches the order of appearance of parameters in the circuit, just like one of the options users have to specify parameter values when defining pubs.