Skip to content

Use IBM Cloud access token to call runtime API #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 30, 2025
Merged

Use IBM Cloud access token to call runtime API #2102

merged 18 commits into from
Apr 30, 2025

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jan 13, 2025 •
edited
Loading

Summary

Bearer tokens have a expires_in value returned from IAM that we need to use to check when/if the token expires

Details and comments

Fixes #2070
Fixes #1874

kt474
kt474 commented Jan 14, 2025
View reviewed changes
@kt474 kt474 marked this pull request as ready for review January 15, 2025 02:34
@kt474 kt474 requested a review from ptristan3 January 16, 2025 15:25
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Mar 18, 2025
@kt474 kt474 force-pushed the api-access-token branch from 9ecc9f8 to 1c16cfa Compare April 10, 2025 19:34
ElePT
ElePT reviewed Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the PR but I think I'm missing the necessary context to give a proper review. Do you have an idea of who we should ping to review? I see there's an assigned reviewer but there hasn't been any action in a few months, things might have changed since then.

@kt474
Copy link
Member Author

kt474 commented Apr 29, 2025

I went through the PR but I think I'm missing the necessary context to give a proper review. Do you have an idea of who we should ping to review?

@cpkurotori do you mind taking a look when you get a chance

@kt474 kt474 mentioned this pull request Apr 29, 2025
Merged
cpkurotori
cpkurotori reviewed Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@cpkurotori cpkurotori left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. Left a suggestion on not passing URL. Also you might want to consider using the IBM core sdk though for this. Could consider using either token manager for minimal changes to this file. Otherwise could use the iam authenticator but would likely require a little refactor.

@kt474
Copy link
Member Author

kt474 commented Apr 30, 2025

Thanks @cpkurotori! Addressed your comments - using IAMTokenManager, getting the cname from the crn, and using expires_in.

kt474 and others added 2 commits April 30, 2025 13:49
@kt474 @cpkurotori
cameron's diff + lint & test fixes
aed9cd2 
Co-authored-by: Cameron Kurotori <cpkurotori@gmail.com>
@kt474
Merge branch 'api-access-token' of https://github.com/kt474/qiskit-ib…
eb5bb95 
…m-runtime into api-access-token
@kt474 kt474 merged commit 19025a6 into Qiskit:main Apr 30, 2025
17 checks passed
@kt474 kt474 mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT left review comments

@cpkurotori cpkurotori cpkurotori approved these changes

@ptristan3 ptristan3 Awaiting requested review from ptristan3

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call Runtime API using Access Token Use bearer token for cloud channel auth
3 participants
@kt474 @cpkurotori @ElePT