Skip to content

Use qiskit-ibm-provider #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 25, 2023
Merged

Use qiskit-ibm-provider #859

merged 9 commits into from
May 25, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 16, 2023 •
edited
Loading

Summary

There are many pieces to remove/refactor so I will break it up into smaller PRs

Duplications removed

  • qpy
  • utils - hgp, ibm_qubit_properties, backend_decoder
  • proxies
  • BackendReservation - this file was never used, I think it was forgotten during the original migration

I will take care of the api related code duplication in a separate PR - in #871

Details and comments

Fixes part of #548

@coveralls
Copy link

coveralls commented May 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5070118368

  • 12 of 12 (100.0%) changed or added relevant lines in 9 files are covered.
  • 143 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+1.3%) to 68.513%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/utils/utils.py 3 53.72%
qiskit_ibm_runtime/accounts/account.py 4 88.37%
qiskit_ibm_runtime/qiskit_runtime_service.py 14 77.35%
qiskit_ibm_runtime/accounts/storage.py 39 25.0%
qiskit_ibm_runtime/accounts/management.py 83 28.69%
Totals Coverage Status
Change from base Build 5070080840: 1.3%
Covered Lines: 2424
Relevant Lines: 3538
💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review May 24, 2023 14:45
@kt474 kt474 added the Changelog: Removal Include in the Removed section of the changelog label May 24, 2023
@kt474 kt474 requested a review from merav-aharoni May 24, 2023 14:56
merav-aharoni
merav-aharoni approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be nice to get rid of all these duplications.
You might as well remove the directories qpy and proxies while you're at it.

@kt474
Copy link
Member Author

kt474 commented May 25, 2023

Looks good! Will be nice to get rid of all these duplications. You might as well remove the directories qpy and proxies while you're at it.

My understanding is that git will automatically get rid of empty directories, but if not I'll go back and remove them

@kt474 kt474 merged commit 2452518 into Qiskit:main May 25, 2023
@kt474 kt474 mentioned this pull request Aug 22, 2023
Closed
This was referenced Dec 14, 2023
Closed
Merged
@kt474 kt474 deleted the use-qiskit-ibm-provider branch April 29, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@merav-aharoni merav-aharoni merav-aharoni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt474 @coveralls @merav-aharoni