Skip to content

Conversation

ikkoham
Copy link
Collaborator

@ikkoham ikkoham commented May 17, 2022

Summary

Same with #1295

Details and comments

@itoko itoko added the stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable label May 17, 2022
Copy link
Collaborator

@hhorii hhorii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhorii hhorii merged commit 5fc5c69 into Qiskit:main May 17, 2022
@ikkoham ikkoham deleted the remove-deprecated-pauli branch May 17, 2022 14:51
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
… observables (Qiskit#165)

* Adapt to base class changes Qiskit/qiskit#8065

* Adapt sampler to base class changes in terra

* Fix black

* Fix lint

* Fix parameter names

* Use Ikko's branch from terra temporarily for testing base class changes

* Fix some failing tests

* Fix couple more tests

* Fix all test failures

* Install rust

* Install rust compiler

* Fix disabling prompt when installing rust

* Run cargo

* Fix parameter name

* Fix black

* Update requirements.txt

* Apply suggestions from code review

Co-authored-by: IKKO HAMAMURA <Ikko.Hamamura1@ibm.com>

* Match _call signature with base classes and remove unnecessary casts

* Try with terra pre pre-release

* Double equals needed

* Fix lint

* qiskit-terra 0.21.0 released, so use that

no longer need to install rust since we are not installing terra from source anymore

qiskit-aer is really a dev dependency for this repo and use the main branch code for now since PR Qiskit/qiskit-aer#1521 is not released yet

* Stop inheriting QiskitTestCase so tests do not fail on deprecation warnings

Co-authored-by: IKKO HAMAMURA <Ikko.Hamamura1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants