Remove hardcoded full paths to icons from desktop files #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzemin
added a commit
that referenced
this pull request
Aug 22, 2015
Remove hardcoded full paths to icons from desktop files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes icons for installations when INSTALL_PREFIX != /usr. According to:
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
icons installed to ${PREFIX]/share/icons not need to have full paths in desktop files.
I use this patch on my system and all icons show up as expected.
Also there are similar icons paths hardcoded in schema files, but I don't if it's ok to remove
them too so I left them alone.